Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deburr player names #92

Merged
merged 4 commits into from
Jan 22, 2020
Merged

feat: deburr player names #92

merged 4 commits into from
Jan 22, 2020

Conversation

garrappachc
Copy link
Member

Deburrs player names before adding them up to the player list on the server.

@garrappachc garrappachc added enhancement New feature or request v1.2 labels Jan 22, 2020
@garrappachc garrappachc self-assigned this Jan 22, 2020
@codecov-io
Copy link

codecov-io commented Jan 22, 2020 •
edited
Loading

Codecov Report

Merging #92 into master will increase coverage by 1.37%.
The diff coverage is 97.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   87.27%   88.64%   +1.37%     
==========================================
  Files          95       95              
  Lines        3323     3374      +51     
  Branches      156      157       +1     
==========================================
+ Hits         2900     2991      +91     
+ Misses        379      338      -41     
- Partials       44       45       +1
Impacted Files Coverage Δ
src/games/services/server-configurator.service.ts 80% <100%> (+55.47%) ⬆️
...games/services/server-configurator.service.spec.ts 97.95% <97.29%> (-2.05%) ⬇️
...game-servers/services/game-servers.service.spec.ts 100% <0%> (ø) ⬆️
src/game-servers/services/game-servers.service.ts 72.22% <0%> (+11.43%) ⬆️
src/games/utils/rcon-commands.ts 81.81% <0%> (+31.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ec724...ef5290d. Read the comment docs.

@garrappachc garrappachc merged commit 8ca2e4d into tf2pickup-org:master Jan 22, 2020
@garrappachc garrappachc deleted the deburr-player-names branch January 22, 2020 22:45
@garrappachc garrappachc added this to the 1.2 milestone Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@garrappachc garrappachc

Labels
enhancement New feature or request
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@garrappachc @codecov-io